Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB/Fix schema for deletion #120

Merged
merged 1 commit into from
Dec 27, 2023
Merged

DB/Fix schema for deletion #120

merged 1 commit into from
Dec 27, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Dec 21, 2023

Description

The schema wasn't converted to string for the table deletion in the retry

Related issues and/or PRs

Changes made

Converted schema to string

Outline the specific changes made in this pull request. Include relevant details, such as added features, bug fixes, code refactoring, or improvements.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

@yito88 yito88 marked this pull request as ready for review December 21, 2023 23:18
@feeblefakie feeblefakie self-requested a review December 26, 2023 10:18
Copy link
Contributor

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@inv-jishnu inv-jishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I have tested the fix and I have add my findings as an update as a comment on slack.
Thank you.

@yito88 yito88 merged commit 23f5610 into master Dec 27, 2023
3 checks passed
@yito88 yito88 deleted the fix/db-table-deletion branch December 27, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants