Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Temurin's base image #24

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Use Temurin's base image #24

merged 2 commits into from
Dec 27, 2023

Conversation

supl
Copy link
Collaborator

@supl supl commented Dec 26, 2023

Description

This PR changes the Dockerfile to use Temurin's Java 8 JRE image as the base image since OpenJDK stopped providing official Docker images and we don't want to maintain in-house Java base image anymore.

Related issues and/or PRs

N/A

Changes made

  • revised Dockerfile

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

@supl supl self-assigned this Dec 26, 2023
kota2and3kan
kota2and3kan reviewed Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!
I left one suggestion.
Please take a look when you have time!

cli/Dockerfile Outdated Show resolved Hide resolved
@supl @kota2and3kan
Update cli/Dockerfile
fe589ee 
Co-authored-by: kota2and3kan <[email protected]>
@supl supl requested a review from kota2and3kan December 26, 2023 14:17
kota2and3kan
kota2and3kan approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

feeblefakie
feeblefakie approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feeblefakie feeblefakie merged commit 6c0ce80 into main Dec 27, 2023
5 checks passed
@feeblefakie feeblefakie deleted the use-temurin-as-base-image branch December 27, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kota2and3kan kota2and3kan kota2and3kan approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@supl supl

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supl @feeblefakie @kota2and3kan