Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename scalar-admin-k8s to scalar-admin-for-kubernetes #21

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

supl
Copy link
Collaborator

@supl supl commented Dec 21, 2023

Description

This PR renames scalar-admin-k8s to scalar-admin-for-kubernetes.

The original discussion is #20 (review) and the meeting (12/21) notes is: https://scalar-labs.atlassian.net/wiki/spaces/SD/pages/1822261303/2023-12-21+Meeting+notes+Scalar+Admin+for+Kubernetes

Related issues and/or PRs

#20

Changes made

  • renamed CLI to scalar-admin-for-kubernetes-cli-{version}.jar
  • renamed Docker image to ghcr.io/scalar-labs/scalar-admin-for-kubernetes:{version}
  • renamed Java package to com.scalar.admin.kubernetes

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

@supl supl self-assigned this Dec 21, 2023
Copy link
Collaborator

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit b5e78fb into main Dec 22, 2023
5 checks passed
@feeblefakie feeblefakie deleted the rename branch December 22, 2023 01:56
@supl supl mentioned this pull request Dec 22, 2023
Merged
6 tasks
@supl supl mentioned this pull request Jan 4, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants