Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote the keyword password in the release workflow #19

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

supl
Copy link
Collaborator

@supl supl commented Nov 21, 2023

Description

This PR tries fixing a bug in the release workflow.

In the error report https://github.com/scalar-labs/scalar-admin-k8s/actions/runs/6938417321/job/18874424947

  echo "***" | base64 -d > ~/.gradle/secring.gpg
  ./gradlew publish \
    -PprojVersion="1.1.0" \
    -Psigning.keyId="***" \
    -Psigning.*** \
    -Psigning.secretKeyRingFile="$(echo ~/.gradle/secring.gpg)" \
    -PossrhUsername="***" \
    -PossrhPassword="***"

However, I am not sure if masking signing.password=xxx to singing.*** is the issue.

Related issues and/or PRs

Changes made

  • revised workflow

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

@supl supl self-assigned this Nov 21, 2023
@supl supl changed the title Quote password Quote they keyword password in the release workflow Nov 21, 2023
@supl supl changed the title Quote they keyword password in the release workflow Quote the keyword password in the release workflow Nov 21, 2023
Copy link
Collaborator

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 3e69443 into main Nov 27, 2023
5 checks passed
@feeblefakie feeblefakie deleted the fix-release-workflow branch November 27, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants