Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Envoy Helm Chart to support Azure Marketplace.
To list Scalar products (ScalarDB Cluster and ScalarDL) on the Azure Marketplace, we have to update our helm chart based on the rules of Azure Marketplace. So, I updated Envoy chart as follows:
spec.template.spec.containers[].image
in thedeployment.yaml
file to pull the container image from ACR for Azure Marketplace.Also, I added the condition (if statement) based on the value of
global.platform
. Basically, Envoy chart is used assubchart
from Scalar products charts (main charts). So, thisglobal.platform
value is passed from the main chart. However, we must set default value invalues.yaml
on the Envoy chart side.You can see more details on the Azure Marketplace support on the ScalarDB Cluster's PR side.
#275
Please take a look!
Related issues and/or PRs
Changes made
charts/envoy/templates/deployment.yaml
to add the Azure Marketplace dedicated configurations.charts/envoy/values.yaml
to addglobal.platform
that is used for switching assumed platform.charts/envoy/README.md
andcharts/envoy/values.yaml
are updated automatically based onvalues.yaml
.Checklist
Additional notes (optional)
N/A
Release notes
N/A