Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[envoy] Support Azure Marketplace #276

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

kota2and3kan
Copy link
Collaborator

@kota2and3kan kota2and3kan commented Sep 26, 2024

Description

This PR updates the Envoy Helm Chart to support Azure Marketplace.

To list Scalar products (ScalarDB Cluster and ScalarDL) on the Azure Marketplace, we have to update our helm chart based on the rules of Azure Marketplace. So, I updated Envoy chart as follows:

  • Update spec.template.spec.containers[].image in the deployment.yaml file to pull the container image from ACR for Azure Marketplace.

Also, I added the condition (if statement) based on the value of global.platform. Basically, Envoy chart is used as subchart from Scalar products charts (main charts). So, this global.platform value is passed from the main chart. However, we must set default value in values.yaml on the Envoy chart side.

You can see more details on the Azure Marketplace support on the ScalarDB Cluster's PR side.
#275

Please take a look!

Related issues and/or PRs

Changes made

  • Update charts/envoy/templates/deployment.yaml to add the Azure Marketplace dedicated configurations.
  • Update charts/envoy/values.yaml to add global.platform that is used for switching assumed platform.
  • charts/envoy/README.md and charts/envoy/values.yaml are updated automatically based on values.yaml.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@kota2and3kan kota2and3kan added improvement scalar envoy PR for Scalar Envoy chart labels Sep 26, 2024
@kota2and3kan kota2and3kan self-assigned this Sep 26, 2024
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 470df83 into main Oct 1, 2024
14 checks passed
@feeblefakie feeblefakie deleted the support-azure-marketplace-envoy branch October 1, 2024 08:42
kota2and3kan added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement scalar envoy PR for Scalar Envoy chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants