Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong sample configuration #244

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix wrong sample configuration #244

merged 2 commits into from
Nov 16, 2023

Conversation

kota2and3kan
Copy link
Collaborator

Description

This PR fixes the wrong sample configurations. The affinity: is missing.

Related issues and/or PRs

N/A

Changes made

  • Update the wrong sample configuration in the document.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@kota2and3kan kota2and3kan added bugfix documentation Improvements or additions to documentation labels Nov 15, 2023
@kota2and3kan kota2and3kan self-assigned this Nov 15, 2023
feeblefakie
feeblefakie approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 870ddfa into main Nov 16, 2023
16 checks passed
@feeblefakie
Copy link
Contributor

@josh-wong Since the change is just one line, I approved it and merged it.
Please update the doc.

@feeblefakie feeblefakie deleted the fix-wrong-sample-configuration branch November 16, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@josh-wong josh-wong Awaiting requested review from josh-wong

Assignees

@kota2and3kan kota2and3kan

Labels
bugfix documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kota2and3kan @feeblefakie