Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a -source and -target version for javac #869

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Jan 15, 2025

This avoids building e.g. IgnoreSuite targeting the latest class file version supported by the JDK used at build time.

#868

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, it's safer to specify those than relying on having to run on the specific Java version

@tgodzik
Copy link
Contributor

tgodzik commented Jan 15, 2025

Could you rebase on main? I fixed the CI as it was missing sbt due to new github images being rolled out

This avoids building e.g. IgnoreSuite targeting the latest class file
version supported by the JDK used at build time.

scalameta#868
@cushon
Copy link
Contributor Author

cushon commented Jan 15, 2025

Could you rebase on main? I fixed the CI as it was missing sbt due to new github images being rolled out

Done, thanks!

@tgodzik tgodzik merged commit 6e58b4f into scalameta:main Jan 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants