Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: look for definition in pc only for local symbols in the current tree #7105

Merged
merged 3 commits into from
Jan 22, 2025
Merged

improvement: look for definition in pc only for local symbols in the current tree #7105

merged 3 commits into from
Jan 22, 2025

Conversation

kasiaMarek
Copy link
Contributor

@tgodzik
Copy link
Contributor

tgodzik commented Jan 21, 2025

Let's try with increased xmx for sbt, 1g was not that large

@tgodzik
Copy link
Contributor

tgodzik commented Jan 21, 2025

Ok, so this didn't work despite the fact that locally I didn't get a lot more memory used. Let's see if it's scaladoc causing this.

@kasiaMarek kasiaMarek requested a review from tgodzik January 22, 2025 10:40
@kasiaMarek kasiaMarek marked this pull request as ready for review January 22, 2025 10:40
tgodzik
tgodzik approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit ad41dcf into scalameta:main Jan 22, 2025
23 checks passed
@kasiaMarek kasiaMarek mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
backport-scala3-pc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasiaMarek @tgodzik