improvement: Don't sent text on didSave #7015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Dec 9, 2024
| @@ -884,9 +884,6 @@ abstract class MetalsLspService( | |||
| ): CompletableFuture[Unit] = { | |||
| val path = params.getTextDocument.getUri.toAbsolutePath | |||
| savedFiles.add(path) | |||
| // read file from disk, we only remove files from buffers on didClose. | |||
| val text = path.toInput.text | |||
There was a problem hiding this comment.
This doesn't seem necessary and for large files might actually be problematic.
tgodzik
force-pushed
the
did-save
branch
4 times, most recently
from
9fd01d9 to
af3b81b
Compare
kasiaMarek
requested changes
Dec 13, 2024
| _.replace("n + 1", "n + 2") | ||
| ) | ||
| _ <- server.didSave("a/src/main/scala/a/Util.scala")(identity) | ||
| _ <- server.didFocus("a/src/main/scala/a/Main.worksheet.sc") |
There was a problem hiding this comment.
I don't think we should ever need didFocus, since it may not be supported, right?
There was a problem hiding this comment.
It's just focus switched to Util.scala and the worksheet doesn't evaluate. This will work in VS Code, though wonder what happens if did focus is not supported
There was a problem hiding this comment.
Maybe we can create a followup for this?
filipwiech
reviewed
Dec 13, 2024
metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala
Outdated
Show resolved
Hide resolved
Previously, we would have clients send us full text on didSave, which was never used. Now, we removed that option. I also removed reading the file from disk to buffers since that file should already be up to date form didChanged
…editor behaviour better
kasiaMarek
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would have clients send us full text on didSave, which was never used.
Now, we removed that option.
I also removed reading the file from disk to buffers since that file should already be up to date form didChanged