Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert creating .scala-build in temporary directory #5918

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Dec 6, 2023

This causes issues with semanticdb, because source root is also set to that build directory and semanticdb ends up in the wrong place.

@tgodzik tgodzik requested a review from kasiaMarek December 6, 2023 13:15
Copy link
Contributor

@kasiaMarek kasiaMarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I wonder if we shouldn't keep disconnectOldBuildServer().asJava.get(100, TimeUnit.MILLISECONDS). Otherwise on exit we don't wait for it and do System.exit(0).

@tgodzik
Copy link
Contributor Author

tgodzik commented Dec 6, 2023

Though I wonder if we shouldn't keep disconnectOldBuildServer().asJava.get(100, TimeUnit.MILLISECONDS). Otherwise on exit we don't wait for it and do System.exit(0).

Makes sense, added it back!

@tgodzik tgodzik merged commit fd22224 into scalameta:main Dec 6, 2023
25 checks passed
@tgodzik tgodzik deleted the revert branch December 6, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants