bugfix: Adjust auto import position for shebang #5860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
requested changes
Nov 21, 2023
| val ammHeaders: List[String] = List("// scala", "// ammonite") | ||
|
|
||
| private def adjustShebang(text: String): String = | ||
| text.replaceFirst(shebang, s"//$shebang") |
There was a problem hiding this comment.
Potentially, you could have "#!" somewhere in the code. We should just replace the first line. I think this is already being done in Trees
There was a problem hiding this comment.
I don't think it's that easy, in Trees it is in first line, but here it is after script wrapper. If #! is somewhere in code, we would not get there with skipPrefixesOffset, so it doesn't change anything. The only thing is, if we have using directives first and then shebang, then the import is inserted after it, but I think thats correct behaviour
tgodzik
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5854