bugfix: Remove old semanticdb files when not needed #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would try to remove semanticdb files from indexes while we used the actual source file. Now, we properly remove files in all indexes and also from interactive semanticdb
kasiaMarek
approved these changes
Oct 26, 2023
| @@ -1168,6 +1168,7 @@ class MetalsLspService( | |||
| compilers.didClose(path) | |||
| trees.didClose(path) | |||
| diagnostics.onClose(path) | |||
| interactiveSemanticdbs.onClose(path) | |||
There was a problem hiding this comment.
There is also def onDelete, shouldn't this be done there too?
There was a problem hiding this comment.
I think this should be fine. If it's deleted and was open we will first get close notification. If a file is deleted that is not open it will not end up in InteractiveSemanticdb in the first place.
jkciesluk
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would try to remove semanticdb files from indexes while we used the actual source file. Now, we properly remove files in all indexes and also from interactive semanticdb.
Related to #5748