report sbt's build progress #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build progress from sbt BSP is now reported. Its notification has a "compile-progress" datakind field, which is formatted the same as "bloop-progress" except for one thing, the "current" field is actually the percentage, so we use 100 for the total.
|
cc @adpi2 I couldn't find a test suite to replicate, but publishing locally had good results. (try compiling scaladex) |
|
also discussed with @adpi2 that perhaps instead of accepting this, we change sbt's output to match we could also standardise this format in the bsp spec |
adpi2
requested changes
Oct 26, 2023
metals/src/main/scala/scala/meta/internal/metals/ForwardingMetalsBuildClient.scala
Show resolved
Hide resolved
adpi2
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build progress from sbt is not being reported. Its notification has a
"compile-progress"datakind field, but is formatted the same as"bloop-progress"except for one thing, the"current"field is actually the percentage, so we use100for the total.