Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: show correct bsp status for focused workspace folder #5772

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

kasiaMarek
Copy link
Contributor

The bsp status is shared between workspace folders in this PR we make sure to always show the one for the workspace folder in focus.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one nitpick about the packages

@@ -0,0 +1,55 @@
package scala.meta.internal.metals
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be in scala.meta.internal.bsp package?

@kasiaMarek kasiaMarek merged commit b5a2d8d into scalameta:main Oct 24, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants