bugfix: add user config promise #5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
user-config-promise
branch
from
4347ad4 to
363ffce
Compare
tgodzik
reviewed
Oct 16, 2023
| else semanticTokens | ||
| } | ||
| for { | ||
| _ <- userConfigPromise.future |
There was a problem hiding this comment.
Potentially, we could have a similar issue with parent code lenses superMethodLensesEnabled, no? Though I think we might send refresh in that case 🤔 We might also send refresh for semantic tokens when they change.
Maybe we should wait for the build server promise, which should most likely be after requesting semantic tokens?
There was a problem hiding this comment.
Code lenses already wait for the buildServerPromise so that's fine.
tgodzik
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5750
The config carried by
didChangeConfigurationis no longer used by metals (only as fallback), the notification is only used as information for metals to update the config, which is done using theworkspace/configurationrequest (more). In #5750 the response toworkspace/configurationcomes after the request for semantic tokens, so thedefaultconfig instead of a user specified one is used.I just wonder if this can happen for other things aside for semantic tokens too (
initializedwaits for config sync to succeed). I considered liftinguserConfigtoFuturein all places but that seems lika a bit of a problematic refactor. Thoughts?