Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Only log messages on resolution #5740

Merged
merged 1 commit into from
Oct 13, 2023
Merged

improvement: Only log messages on resolution #5740

merged 1 commit into from
Oct 13, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Oct 12, 2023

Previously, we would log every time a presentation compiler was used.

@tgodzik
improvement: Only log messages on resolution
0c6466c 
Previously, we would log every time a presentation compiler was used.
kasiaMarek
kasiaMarek approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@kasiaMarek kasiaMarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

jkciesluk
jkciesluk approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tgodzik tgodzik merged commit fa9d2df into scalameta:main Oct 13, 2023
@tgodzik tgodzik deleted the log-properly branch October 13, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkciesluk jkciesluk jkciesluk approved these changes

@kasiaMarek kasiaMarek kasiaMarek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgodzik @kasiaMarek @jkciesluk