Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: handle created build server config before all content written #5734

Merged
merged 1 commit into from
Oct 12, 2023
Merged

bugfix: handle created build server config before all content written #5734

merged 1 commit into from
Oct 12, 2023

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Oct 10, 2023 •
edited
Loading

@kasiaMarek kasiaMarek force-pushed the scala-cli-bsp-parsing-error branch from a0dc5b9 to a8c77d5 Compare October 10, 2023 13:36
@kasiaMarek kasiaMarek requested a review from tgodzik October 11, 2023 08:23
tgodzik
tgodzik approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasiaMarek kasiaMarek merged commit ef544a6 into scalameta:main Oct 12, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasiaMarek @tgodzik