Bsp errors in status #5726
Merged
Bsp errors in status #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
bsp-errors-in-status
branch
from
3373773 to
04938f5
Compare
kasiaMarek
force-pushed
the
bsp-errors-in-status
branch
from
04938f5 to
95dd81a
Compare
kasiaMarek
force-pushed
the
bsp-errors-in-status
branch
from
c080bef to
bc92724
Compare
jkciesluk
requested changes
Oct 27, 2023
metals/src/main/scala/scala/meta/internal/metals/doctor/Doctor.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/doctor/Doctor.scala
Outdated
Show resolved
Hide resolved
mtags-shared/src/main/scala/scala/meta/internal/metals/ReportContext.scala
Show resolved
Hide resolved
mtags-shared/src/main/scala/scala/meta/internal/metals/ReportContext.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/bsp/ConnectionBspStatus.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/bsp/ConnectionBspStatus.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/bsp/ConnectionBspStatus.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/bsp/ConnectionBspStatus.scala
Outdated
Show resolved
Hide resolved
kasiaMarek
force-pushed
the
bsp-errors-in-status
branch
from
b2002b7 to
c406ddc
Compare
jkciesluk
approved these changes
Oct 30, 2023
| "warn", | ||
| show = true, | ||
| tooltip = message.trimTo(TOOLTIP_MAX_LENGTH), | ||
| command = ServerCommands.RunDoctor.id, |
There was a problem hiding this comment.
As a follow up, would it be possible (probably on vs-code side) to make doctor open on the part with error reports?
There was a problem hiding this comment.
Yeah, that sounds like a good idea.
There was a problem hiding this comment.
We should also open them in that case, currently they are folded.
tgodzik
reviewed
Nov 8, 2023
metals/src/main/scala/scala/meta/internal/bsp/ConnectionBspStatus.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5692