Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix reporting "no response error" after laptop in sleep mode #5716

Merged
merged 1 commit into from
Oct 11, 2023
Merged

bugfix: fix reporting "no response error" after laptop in sleep mode #5716

merged 1 commit into from
Oct 11, 2023

Conversation

kasiaMarek
Copy link
Contributor

Account for the possibility, that laptop might be coming out of sleep mode, that lasted less than 5min (so not idle state entered). Instead of keeping a state, we now simply check if the lastPing was send < 2*interval ago to perform any checks.

2023.10.05 11:30:21 INFO  Processing workspace/buildTargets
2023.10.05 11:31:21 DEBUG server liveness monitor: pinging build server...
2023.10.05 11:31:21 INFO  Processing workspace/buildTargets
2023.10.05 11:34:52 DEBUG server liveness monitor detected no response
2023.10.05 11:34:52 DEBUG server liveness monitor: pinging build server...
2023.10.05 11:34:52 INFO  Processing workspace/buildTargets

tgodzik
tgodzik approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasiaMarek kasiaMarek force-pushed the liveness-monitor-after-sleep branch from 2a80cae to d2674e4 Compare October 6, 2023 10:11
@kasiaMarek kasiaMarek force-pushed the liveness-monitor-after-sleep branch from d2674e4 to f5ad06d Compare October 6, 2023 15:05
@kasiaMarek kasiaMarek merged commit bdd6c6e into scalameta:main Oct 11, 2023
22 of 24 checks passed
@kasiaMarek kasiaMarek mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@jkciesluk jkciesluk Awaiting requested review from jkciesluk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasiaMarek @tgodzik