navigate to decompiled class if no source #3411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it was useful to have Absolute Path as it has more utility methods and also probably some validation. That might not be 100 percent needed in all places. |
tgodzik
reviewed
Jan 5, 2022
| .map(f => { | ||
| val uri = f.jar.toURI.toString() | ||
| val fullURI = | ||
| URI.create(s"jar:${uri}!/${symbol.stripSuffix("#")}.class") |
There was a problem hiding this comment.
This might not work for some more complex Scala symbols such as inner classes 🤔
In that case we might want to use ClasspathSymbols and find the class that contains the symbol.
| .map(jarPath => List("--extraclasspath", jarPath.toString)) | ||
| .getOrElse(List.empty) | ||
| val args = extraClassPath ::: List( | ||
| "--analyseas", |
There was a problem hiding this comment.
No - although it does look it. The options is meant to mean ANALYSE_AS. Either jar or class
|
Thanks for this nice feature! Does it also works for scala js? |
|
@doofin I haven't used scala js. Can you give an example of what you mean? |
|
This is being done together with #3750, so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial stab at scalameta/metals-feature-requests#210
I've no idea whether this is done in the correct area of code but it works so 🤷. If it is the correct area then I'll follow up with some tests.
One thing I've noticed is that
scala.meta.internal.mtags.SymbolDefinition(and a number of other classes used for passing file locations around) useAbsolutePathto refer to file locations. This is handy becausenio.Pathvalidates that the format is correct and there are lots of useful Path methods but it's not so handy when all that's really going on is URIs are being passed around.Downsides of using AbsolutePath are that any
jar:file///somejar.jar!/someclass.javastyle reference has to be opened in javaFileSystems#newFileSystem, even if you're not accessing it, or it throws an exception. Also - you can't use a virtual URI e.g.metalsDecode:jar:file:///somejar.jar!/someclass.class.cfrin AbsolutePath because it wrapsnio.Pathand I've not implemented ametalsDecodefilesystem as I think that's over the top.Is there a reason for using AbsolutePath rather than URI in all these places - or is it just historical?