improvement: Allow to override metals java home #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
changed the title
tgodzik
force-pushed
the
override-java-home
branch
from
4eb4af5 to
48aa363
Compare
Peviously, if use had JAVA_HOME and java on PATH pointing to JDK 11, we would download JDK 17 using coursier. This however might not work if there is no internet and there was no way to work around that. Now, we allow users to specify an override for those cases. Fixes scalameta#1558
tgodzik
force-pushed
the
override-java-home
branch
from
48aa363 to
50732c5
Compare
kasiaMarek
reviewed
Jan 8, 2025
| return workspace | ||
| .getConfiguration("metals") | ||
| .get<string>(UserConfiguration.MetalsJavaHome) | ||
| ?.trim(); |
There was a problem hiding this comment.
Maybe if empty string you want to return undefined?
Co-authored-by: Katarzyna Marek <[email protected]>
tgodzik
force-pushed
the
override-java-home
branch
from
a8e5b7d to
c745a6b
Compare
kasiaMarek
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peviously, if use had JAVA_HOME and java on PATH pointing to JDK 11, we would download JDK 17 using coursier. This however might not work if there is no internet and there was no way to work around that. Now, we allow users to specify an override for those cases.
Fixes #1558