improvement: Return undefined if empty string

scalameta · Jan 8, 2025 · a8e5b7d · a8e5b7d
1 parent 483bcf2
commit a8e5b7d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/metals-vscode/src/util.ts b/packages/metals-vscode/src/util.ts
@@ -116,10 +116,12 @@ export function getJavaVersionFromConfig() {
 }
 
 export function getJavaVersionOverride(): string | undefined {
-  return workspace
+  const javaVersion = workspace
     .getConfiguration("metals")
     .get<string>(UserConfiguration.MetalsJavaHome)
     ?.trim();
+  if (javaVersion && javaVersion.length > 0) return javaVersion;
+  else return undefined;
 }
 
 export async function fetchFrom(