Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in styling of skeleton and segment tree UI #8307

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 7, 2025

The token was accidentally introduced in #8295.

Without fix:
image
image

With fix:
image
image

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • see screenshots; should be enough

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jan 7, 2025
Copy link
Contributor

coderabbitai bot commented Jan 7, 2025

📝 Walkthrough

Walkthrough

The pull request introduces several updates to the WEBKNOSSOS project, focusing on enhancing user experience and functionality. Key changes include adding dataset volume display in tooltips, improving performance for data loading, and introducing "Selective Segment Visibility" for segmentation layers. The changelog documents modifications to naming conventions, tool interactions, and various bug fixes. The project also removes support for older HTTP API versions and adjusts design tokens in the frontend theming.

Changes

File Change Summary
CHANGELOG.unreleased.md - Added new features like dataset volume tooltips and segment visibility
- Renamed "resolution" to "magnification"
- Documented performance optimizations and UI improvements
- Noted removal of HTTP API versions 3 and 4
frontend/javascripts/theme.tsx - Removed colorPrimaryBg property from globalDesignToken

Possibly related PRs

Suggested labels

bug, css, frontend

Suggested reviewers

  • hotzenklotz
  • MichaelBuessemeyer

Poem

🐰 Hop, hop, through code so bright,
Segments now dance with new delight!
Magnification takes its flight,
Tooltips gleaming, colors just right,
A rabbit's code review takes might! 🔍


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.unreleased.md (1)

46-46: LGTM! Consider adding more details about the visual impact.

The changelog entry is well-placed in the "Fixed" section and correctly references the PR. To provide better historical context, consider expanding the entry to briefly describe the visual impact, similar to:

-Fixed regression in styling of segment and skeleton tree tab. [#8307](https://github.com/scalableminds/webknossos/pull/8307)
+Fixed regression in styling of segment and skeleton tree tab where the UI components appeared misaligned/distorted. [#8307](https://github.com/scalableminds/webknossos/pull/8307)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cad8de3 and f1c8286.

📒 Files selected for processing (2)
  • CHANGELOG.unreleased.md (1 hunks)
  • frontend/javascripts/theme.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • frontend/javascripts/theme.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: circleci_build

@philippotto philippotto merged commit 5a556be into master Jan 7, 2025
3 checks passed
@philippotto philippotto deleted the fix-tree-style-regression branch January 7, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants