-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in styling of skeleton and segment tree UI #8307
Conversation
📝 WalkthroughWalkthroughThe pull request introduces several updates to the WEBKNOSSOS project, focusing on enhancing user experience and functionality. Key changes include adding dataset volume display in tooltips, improving performance for data loading, and introducing "Selective Segment Visibility" for segmentation layers. The changelog documents modifications to naming conventions, tool interactions, and various bug fixes. The project also removes support for older HTTP API versions and adjusts design tokens in the frontend theming. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.unreleased.md (1)
46-46
: LGTM! Consider adding more details about the visual impact.The changelog entry is well-placed in the "Fixed" section and correctly references the PR. To provide better historical context, consider expanding the entry to briefly describe the visual impact, similar to:
-Fixed regression in styling of segment and skeleton tree tab. [#8307](https://github.com/scalableminds/webknossos/pull/8307) +Fixed regression in styling of segment and skeleton tree tab where the UI components appeared misaligned/distorted. [#8307](https://github.com/scalableminds/webknossos/pull/8307)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.unreleased.md
(1 hunks)frontend/javascripts/theme.tsx
(0 hunks)
💤 Files with no reviewable changes (1)
- frontend/javascripts/theme.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: circleci_build
The token was accidentally introduced in #8295.
Without fix:
With fix:
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)