Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate HTTP API Version 8 #8142

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Activate HTTP API Version 8 #8142

merged 2 commits into from
Oct 23, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 23, 2024

I forgot to bump that number in #7386

This is needed to access the explicit /api/v8/ routes, e.g. https://webknossos.org/api/v8/buildinfo currently fails while v7 works. But webknossos.versioned.routes already provides v8.

This blocks scalableminds/webknossos-libs#1185

@fm3 fm3 self-assigned this Oct 23, 2024
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, sorry I did not know about this 🙈

The changes lgtm 🎉

@fm3
Copy link
Member Author

fm3 commented Oct 23, 2024

Oh no, sorry I did not know about this

No worries, since we hadn’t started adapting the libs, nobody noticed until now 😅 Also this is pretty new and I’m still getting used to it myself. That’s why I also added it into the common-edge-cases.md thing

@fm3 fm3 merged commit 7099fe3 into master Oct 23, 2024
2 checks passed
@fm3 fm3 deleted the api-version-eight branch October 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants