Set default data format with enviroment variable #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanrz
requested changes
Oct 24, 2023
| DataFormat.WKW if not os.environ.get("DATA_FORMAT") == "zarr3" else DataFormat.Zarr3 | ||
| ) | ||
| DEFAULT_CHUNKS_PER_SHARD = ( | ||
| Vec3Int.full(32) if DEFAULT_DATA_FORMAT == DataFormat.WKW else Vec3Int.full(16) |
There was a problem hiding this comment.
I would make a separate env var WK_DEFAULT_CHUNKS_PER_SHARD for this.
normanrz
requested changes
Oct 24, 2023
normanrz
reviewed
Oct 25, 2023
normanrz
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
DEFAULT_DATA_FORMATused when writing datasets can now be set with the environment variableDATA_FORMAT. If the environment variable is not set the default data format is still wkw. When the data format is set to Zarr3 a lower value is set forDEFAULT_CHUNKS_PER_SHARD.Todos: