Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable zarrita by default #950

Merged
merged 8 commits into from
Oct 12, 2023
Merged

Enable zarrita by default #950

merged 8 commits into from
Oct 12, 2023

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Oct 9, 2023 •
edited
Loading

Description:

  • Zarrita is always installed and now the default for Zarr and Zarr3 datasets
  • The WK_USE_ZARRITA env variable is no longer required
  • Writes out OME metadata for both Zarr and Zarr3 datasets.
  • Reorganizes the imports to use relative imports in the webknossos package

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog

@normanrz normanrz self-assigned this Oct 9, 2023
@normanrz normanrz marked this pull request as ready for review October 9, 2023 20:22
@normanrz normanrz requested a review from markbader October 10, 2023 09:50
@normanrz
more relative imports
98efc76
@normanrz
merge
8dd2a64
@normanrz
Zarr volume annotations (#952)
bb177b8 
* Adds support for Zarr3-based volume annotations
* adds test
* defaults for Volume
* changelog
* adds test zip
* merge
* merge
* test_annotation with id
* Update webknossos/webknossos/dataset/dataset.py

Co-authored-by: Florian M <[email protected]>
* Update webknossos/webknossos/annotation/annotation.py

Co-authored-by: Florian M <[email protected]>
* pr feedback
* ci
@normanrz
Copy link
Member Author

Sorry, I prematurely merged #952 in this branch. Please focus your review on these commits https://github.com/scalableminds/webknossos-libs/pull/950/files/8dd2a641c8326e080e27ce8cad98bb9b57b986f7

markbader
markbader reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@markbader markbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@normanrz normanrz merged commit 2a5d1c0 into master Oct 12, 2023
18 checks passed
@normanrz normanrz deleted the stable-zarrita branch October 12, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbader markbader markbader approved these changes

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@normanrz @markbader