Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mag setup in case of non public UPath. #1222

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

valentin-pinkau
Copy link
Member

@valentin-pinkau valentin-pinkau commented Nov 28, 2024

Description:

  • This PR fixes the setup of mags when their path is non public

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Added / Updated Tests

@markbader
Copy link
Contributor

LGTM 🙂

@markbader
Copy link
Contributor

markbader commented Nov 28, 2024

Failing tests are probably due to changed requests that are not yet captured by vcr-py. You might try to run ./test.sh --refresh-snapshots in the webknossos directory. But as vcr-py has some problems recently, I am not sure if it will fix all tests.

@markbader
Copy link
Contributor

Please add a short note in the changelog file about the added auth token.

@valentin-pinkau
Copy link
Member Author

This is currently blocked by #1198

@valentin-pinkau valentin-pinkau merged commit 006083f into master Dec 19, 2024
19 checks passed
@valentin-pinkau valentin-pinkau deleted the fix_setup_mag_in_case_of_non_public branch December 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants