Skip to content

Commit

Permalink
Restore cubing main method which takes namespace args (#507)
Browse files Browse the repository at this point in the history
* restore cubing main method which takes namespace args (aka cube_with_args)

* update and clean up changelogs
  • Loading branch information
philippotto authored Dec 8, 2021
1 parent 26ecd38 commit 8cf330c
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 10 deletions.
3 changes: 0 additions & 3 deletions webknossos/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ For upgrade instructions, please check the respective *Breaking Changes* section
## [v0.8.24](https://github.com/scalableminds/webknossos-libs/releases/tag/v0.8.24) - 2021-11-30
[Commits](https://github.com/scalableminds/webknossos-libs/compare/v0.8.23...v0.8.24)

### Fixed
- Fixed `--version` CLI argument. [#493](https://github.com/scalableminds/webknossos-libs/pull/493)


## [v0.8.23](https://github.com/scalableminds/webknossos-libs/releases/tag/v0.8.23) - 2021-11-29
[Commits](https://github.com/scalableminds/webknossos-libs/compare/v0.8.22...v0.8.23)
Expand Down
16 changes: 14 additions & 2 deletions wkcuber/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,26 @@ For upgrade instructions, please check the respective *Breaking Changes* section
### Breaking Changes in Config & CLI

### Added
- `wkcuber.convert_raw` conversion tool for raw binary data files. [#498](https://github.com/scalableminds/webknossos-libs/pull/498)
- Added the `wkcuber` executable that is installed when the package is installed. [#495](https://github.com/scalableminds/webknossos-libs/pull/495)
- Added importable `cube_with_args` function to main module of wkcuber. [#507](https://github.com/scalableminds/webknossos-libs/pull/507)

### Changed

### Fixed


## [v0.8.25](https://github.com/scalableminds/webknossos-libs/releases/tag/v0.8.25) - 2021-12-07
[Commits](https://github.com/scalableminds/webknossos-libs/compare/v0.8.24...v0.8.25)

### Added
- `wkcuber.convert_raw` conversion tool for raw binary data files. [#498](https://github.com/scalableminds/webknossos-libs/pull/498)
- Added the `wkcuber` executable that is installed when the package is installed. [#495](https://github.com/scalableminds/webknossos-libs/pull/495)

## [v0.8.24](https://github.com/scalableminds/webknossos-libs/releases/tag/v0.8.24) - 2021-11-30
[Commits](https://github.com/scalableminds/webknossos-libs/compare/v0.8.23...v0.8.24)

### Fixed
- Fixed `--version` CLI argument. [#493](https://github.com/scalableminds/webknossos-libs/pull/493)

## [v0.8.23](https://github.com/scalableminds/webknossos-libs/releases/tag/v0.8.23) - 2021-11-29
[Commits](https://github.com/scalableminds/webknossos-libs/compare/v0.8.18...v0.8.23)

Expand Down
13 changes: 8 additions & 5 deletions wkcuber/wkcuber/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
main as auto_detect_and_run_conversion,
)
from .versioning import get_available_version
from argparse import ArgumentParser
from argparse import Namespace, ArgumentParser
from pathlib import Path


Expand Down Expand Up @@ -71,10 +71,7 @@ def create_parser() -> ArgumentParser:
return parser


def main() -> None:
args = create_parser().parse_args()
setup_logging(args)

def cube_with_args(args: Namespace) -> None:
if args.isotropic is not None:
raise DeprecationWarning(
"The flag 'isotropic' is deprecated. Consider using '--sampling_mode isotropic' instead."
Expand Down Expand Up @@ -107,5 +104,11 @@ def main() -> None:
refresh_metadata(args.target_path)


def main() -> None:
args = create_parser().parse_args()
setup_logging(args)
cube_with_args(args)


if __name__ == "__main__":
main()

0 comments on commit 8cf330c

Please sign in to comment.