Skip to content

Commit

Permalink
FinishUpload: stop retrying on error (#702)
Browse files Browse the repository at this point in the history
* FinishUpload: stop retrying on error

* changelog
  • Loading branch information
fm3 authored Apr 20, 2022
1 parent 8a43c9e commit 7364802
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions webknossos/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ For upgrade instructions, please check the respective *Breaking Changes* section

### Fixed

- Fixed a bug where the server’s error message during dataset upload was not displayed to the user. [#702](https://github.com/scalableminds/webknossos-libs/pull/702)


## [0.9.19](https://github.com/scalableminds/webknossos-libs/releases/tag/v0.9.19) - 2022-04-11
[Commits](https://github.com/scalableminds/webknossos-libs/compare/v0.9.18...v0.9.19)
Expand Down
5 changes: 2 additions & 3 deletions webknossos/webknossos/client/_upload_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,8 @@ def upload_dataset(
}
),
)
if response.status_code == 200:
if response.status_code == 200 or response.status_code == 400:
break
else:
assert response.status_code == 200, response
assert response.status_code == 200, response

return f"{context.url}/datasets/{context.organization_id}/{new_dataset_name}/view"

0 comments on commit 7364802

Please sign in to comment.