Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os-lib 0.10.2, upickle 3.3.1 #53

Merged
merged 5 commits into from
Aug 5, 2024
Merged

os-lib 0.10.2, upickle 3.3.1 #53

merged 5 commits into from
Aug 5, 2024

Conversation

sideeffffect
Copy link
Contributor

@sideeffffect sideeffffect commented Jul 15, 2024

fixes #52

@bishabosha
Copy link
Member

im not sure how it works, but you also need to generate the changelog files

@bishabosha
Copy link
Member

ok please can you also run scala-cli changelog -- --overwrite which generates the new changelogs

@bishabosha bishabosha requested a review from adpi2 July 16, 2024 12:41
@bishabosha
Copy link
Member

@adpi2 are you meant to update the changelogs in a PR like this, or only when we make a new tag?

@adpi2
Copy link
Member

adpi2 commented Jul 16, 2024

In any PR that changes the dependencies.

@sideeffffect
Copy link
Contributor Author

I think it's very suspicious that it's taking this long and that there are OutOfMemory errors from Coursier...
Could some Toolkit maintainer have a look at this, please? 🙏 @bishabosha or @adpi2 ?

@bishabosha
Copy link
Member

@adpi2 knows more about this but is on vacation

@sideeffffect
Copy link
Contributor Author

@adpi2 ping 😸

@adpi2
Copy link
Member

adpi2 commented Jul 30, 2024

I'll be back to work tomorrow. Thanks for your patience.

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why there was a OOM as I did not manage to reproduce it locally.

But the thing is we needed to update the development version from 0.4.0, which is already released, to 0.5.0. After that change everything is working fine again. I am going to add a CONTRIBUTING.md file to clarify that process.

@adpi2 adpi2 merged commit 34f252f into scala:main Aug 5, 2024
1 check passed
@sideeffffect sideeffffect deleted the patch-1 branch August 5, 2024 10:39
@sideeffffect
Copy link
Contributor Author

Is there a reason why it's not on Maven Central yet?
https://repo1.maven.org/maven2/org/scala-lang/toolkit_native0.5_3/

The job seems to have finished successfully https://github.com/scala/toolkit/actions/runs/10246371483/job/28343314234

@sideeffffect
Copy link
Contributor Author

Actually it failed, yet everything is green 🙀

Uploading files failed!
Possible causes:
- incorrect Sonatype credentials
- incorrect Sonatype server was used, try 'central-s01'
 -> consult publish subcommand documentation

https://github.com/scala/toolkit/actions/runs/10246371483/job/28343314234#step:11:120

@adpi2
Copy link
Member

adpi2 commented Aug 5, 2024

Actually it failed, yet everything is green 🙀

Oh thanks for catching that. I think it is an issue with the Sonatype credentials and I am going to try again.

@lbialy
Copy link

lbialy commented Aug 5, 2024

@Gedochao hey, have you seen this? Looks like it's not only mill then.

@Gedochao
Copy link

Gedochao commented Aug 5, 2024

@Gedochao hey, have you seen this? Looks like it's not only mill then.

The error is different, though. It's likely the Sonatype creds issue everyone had last week. Might be sufficient to regenerate the token.

@adpi2
Copy link
Member

adpi2 commented Aug 5, 2024

The error is different, though. It's likely the Sonatype creds issue everyone had last week. Might be sufficient to regenerate the token.

Yes that's what I did. Let's see if it fixes the release.

@adpi2
Copy link
Member

adpi2 commented Aug 5, 2024

It's working better now: https://oss.sonatype.org/content/repositories/public/org/scala-lang/toolkit_2.13/0.5.0/

@sideeffffect
Copy link
Contributor Author

@sideeffffect
Copy link
Contributor Author

What bout the fact that failed publish didn't cause the CI to fail/become red?
Is that an issue with the CI setup of this repository? Or an issue with Mill?

@adpi2
Copy link
Member

adpi2 commented Aug 6, 2024

Is that an issue with the CI setup of this repository? Or an issue with Mill?

That's a good question. It could be that we have continue-on-error: true in our workflow for some historical reason. But I think we can remove it now.

#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update os-lib to 0.10.2
5 participants