-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os-lib 0.10.2, upickle 3.3.1 #53
Conversation
im not sure how it works, but you also need to generate the changelog files |
ok please can you also run |
@adpi2 are you meant to update the changelogs in a PR like this, or only when we make a new tag? |
In any PR that changes the dependencies. |
I think it's very suspicious that it's taking this long and that there are OutOfMemory errors from Coursier... |
@adpi2 knows more about this but is on vacation |
@adpi2 ping 😸 |
I'll be back to work tomorrow. Thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why there was a OOM as I did not manage to reproduce it locally.
But the thing is we needed to update the development version from 0.4.0, which is already released, to 0.5.0. After that change everything is working fine again. I am going to add a CONTRIBUTING.md
file to clarify that process.
Is there a reason why it's not on Maven Central yet? The job seems to have finished successfully https://github.com/scala/toolkit/actions/runs/10246371483/job/28343314234 |
Actually it failed, yet everything is green 🙀
https://github.com/scala/toolkit/actions/runs/10246371483/job/28343314234#step:11:120 |
Oh thanks for catching that. I think it is an issue with the Sonatype credentials and I am going to try again. |
@Gedochao hey, have you seen this? Looks like it's not only mill then. |
The error is different, though. It's likely the Sonatype creds issue everyone had last week. Might be sufficient to regenerate the token. |
Yes that's what I did. Let's see if it fixes the release. |
It's working better now: https://oss.sonatype.org/content/repositories/public/org/scala-lang/toolkit_2.13/0.5.0/ |
What bout the fact that failed publish didn't cause the CI to fail/become red? |
That's a good question. It could be that we have |
fixes #52