Exclusive capabilities V2 #22338
Draft
Exclusive capabilities V2 #22338
+2,507
−611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subsumes check mistakenly allowed any capability to subsume `cap`, since `cap` is expanded as `caps.cap`, and by the path subcapturing rule `caps.cap <: caps`, where the capture set of `caps` is empty. This allowed quite a few hidden errors to go through. This commit fixes the subcapturing issue and all downstream issues caused by that fix. In particular: - Don't use path comparison for `x subsumes caps.cap` - Don't allow an opened existential on the left of a comparison to leak into a capture set on the right. This would give a "leak" error later in healCaptures. - Print pre-cc annotated capturing types with @retains annotations with `^`. The annotation is already rendered as a set in this case, but the `^` was missing. - Don't recheck `_` right hand sides of uninitialized variables. These were handled in ways that broke freshness checking. The new `uninitialied` scheme does not have this problem.
This is necessary because the compiler is free in previous phases to dealias or not. Therefore, capture checking should not depend on aliasing. The main difference is that now arguments to type aliases are not necessarily boxed. They are boxed only if they need boxing in the dealiased type.
When printing a type `C^` where `C` extends `Capability`, don't show the `^`. This is overridden under -Yprint-debug.
odersky
force-pushed
the
exclusive-capabilities-squashed
branch
from
b4eaf3d to
2d9af0d
Compare
- Add Mutable trait and mut modifier.
- Add dedicated tests `isMutableVar` and `isMutableVarOrAccessor`
so that update methods can share the same flag `Mutable` with mutable vars.
- Disallow update methods overriding normal methods
- Disallow update methods which are not members of classes extending Mutable
- Add design document from papers repo to docs/internals
- Add readOnly capabilities
- Implement raeadOnly access
- Check that update methods are only called on references with exclusive capture sets.
- Use cap.rd as default capture set of Capability subtypes
- Make Mutable a Capability, this means Mutable class references get {cap.rd} as
default capture set.
- Use {cap} as captu
….toCap If existentials are mapped to fresh, it matters where they are opened. Pure or not arguments don't have anything to do with that.
odersky
force-pushed
the
exclusive-capabilities-squashed
branch
3 times, most recently
from
87cc5e1 to
314cdc5
Compare
These are represented as Fresh.Cap(hidden) where hidden is the set of
capabilities subsumed by a fresh. The underlying representation is as
an annotated type `T @annotation.internal.freshCapability`.
Require -source `3.7` for caps to be converted to Fresh.Cap
Also:
- Refacture and document CaputureSet
- Make SimpleIdentitySets showable
- Refactor VarState
- Drop Frozen enum
- Make VarState subclasses inner classes of companion object
- Rename them
- Give implicit parameter VarState of subCapture method a default value
- Fix printing of capturesets containing cap and some other capability
- Revise handing of @uncheckedAnnotation
odersky
force-pushed
the
exclusive-capabilities-squashed
branch
from
314cdc5 to
9575d86
Compare
Check separation from source 3.7 on. We currently only check applications, other areas of separation checking are still to be implemented.
odersky
force-pushed
the
exclusive-capabilities-squashed
branch
from
9575d86 to
bc2b33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to squash commits and arrange them in a more logical order