Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ScAS : adapt to new given syntax #22302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rjolly
Copy link
Contributor

@rjolly rjolly commented Jan 3, 2025

No description provided.

@rjolly rjolly force-pushed the main branch 2 times, most recently from 3a516df to 140ebb6 Compare January 3, 2025 14:40
@rjolly rjolly marked this pull request as draft January 6, 2025 05:11
@rjolly rjolly marked this pull request as ready for review January 6, 2025 11:49
@rjolly rjolly force-pushed the main branch 2 times, most recently from ce82cdf to 6590955 Compare January 6, 2025 17:42
@SethTisue
Copy link
Member

Do you have a link to the PR where you made the needed changes? I'd be interested to see it, just out of curiosity.

@rjolly rjolly marked this pull request as draft January 7, 2025 06:19
@rjolly rjolly marked this pull request as ready for review January 7, 2025 10:36
@rjolly
Copy link
Contributor Author

rjolly commented Jan 7, 2025

@SethTisue Unfortunately, I do not use PRs (yet?). It's essentially in dotty-staging/scas@4ef0d85 . Other than that, the main burden was to change abstract givens to the new deferred mechanism, which is spread over the 8 subsequent commits (you have to look for deferred). Of particular interest is dotty-staging/scas@d22f29b , which introduces a by-name given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants