Refactor handling of rechecked types #22229
Merged
+105
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always store new types on rechecking
- Store them in a hashmap which is associated with the rechecker of the
current compilation unit
- After rechecking is done, the map is forgotten, unless keepTypes is true.
Under keepTypes, then map is kept in an attachment of the unit's root tree.
Change in nomenclature:
knownType --> nuType
rememberType --> setNuType
hasRememberedType --> hasNuType
mbovel
reviewed
Dec 21, 2024
| */ | ||
| def setupUnit(tree: Tree, recheckDef: DefRecheck)(using Context): Unit |
There was a problem hiding this comment.
Could type DefRecheck be removed? It seemed it's not used anymore after this change.
mbovel
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in nomenclature: