Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the length of the arguments passed to java in scaladoc.bat #21033

Closed
wants to merge 4 commits into from
Closed

Reduce the length of the arguments passed to java in scaladoc.bat #21033

wants to merge 4 commits into from

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Jul 4, 2024 •
edited
Loading

@hamzaremmal hamzaremmal force-pushed the win-launcher-patch branch from f5a71e7 to a116f66 Compare July 4, 2024 18:32
@hamzaremmal hamzaremmal self-assigned this Jul 4, 2024
@hamzaremmal hamzaremmal force-pushed the win-launcher-patch branch from a116f66 to 523a1b8 Compare July 4, 2024 19:02
@hamzaremmal hamzaremmal force-pushed the win-launcher-patch branch from 9398ef6 to 9d6c6cb Compare July 4, 2024 21:06
@hamzaremmal hamzaremmal force-pushed the win-launcher-patch branch 4 times, most recently from cdbd69a to a3c7cc1 Compare July 5, 2024 14:17
@hamzaremmal hamzaremmal marked this pull request as ready for review July 5, 2024 14:30
@hamzaremmal hamzaremmal requested a review from bishabosha July 5, 2024 14:30
@hamzaremmal hamzaremmal assigned bishabosha and unassigned hamzaremmal Jul 5, 2024
@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jul 5, 2024
@hamzaremmal hamzaremmal force-pushed the win-launcher-patch branch from a3c7cc1 to 9cfe1f6 Compare July 5, 2024 14:56
@hamzaremmal
Copy link
Member Author

The @file feature is only available since Java 9: https://www.oracle.com/java/technologies/javase/9-notes.html#JDK-8162810

@hamzaremmal hamzaremmal closed this Jul 5, 2024
@hamzaremmal hamzaremmal deleted the win-launcher-patch branch July 5, 2024 15:51
@WojciechMazur WojciechMazur removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kordyjan Kordyjan Kordyjan approved these changes

@bishabosha bishabosha Awaiting requested review from bishabosha

Assignees

@bishabosha bishabosha

Labels
stat:do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New classpath management system in launchers might break
4 participants
@hamzaremmal @Kordyjan @bishabosha @WojciechMazur