Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set AppliedType#validSuper after AppliedType#cachedSuper #20553

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Only set AppliedType#validSuper after AppliedType#cachedSuper #20553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compiler/src/dotty/tools/dotc/core/Types.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4646,18 +4646,18 @@ object Types extends TypeUtils {

override def superType(using Context): Type =
if ctx.period != validSuper then
validSuper = if (tycon.isProvisional) Nowhere else ctx.period
var superIsProvisional = tycon.isProvisional
cachedSuper = tycon match
case tycon: HKTypeLambda => defn.AnyType
case tycon: TypeRef if tycon.symbol.isClass => tycon
case tycon: TypeProxy =>
if validSuper != Nowhere && args.exists(_.isProvisional) then
superIsProvisional ||= args.exists(_.isProvisional)
// applyIfParameterized may perform eta-reduction leading to different
// variance annotations depending on the instantiation of type params
// see tests/pos/typeclass-encoding3b.scala:348 for an example
validSuper = Nowhere
tycon.superType.applyIfParameterized(args)
case _ => defn.AnyType
validSuper = if superIsProvisional then Nowhere else ctx.period
cachedSuper

override def translucentSuperType(using Context): Type = tycon match {
Expand Down
22 changes: 22 additions & 0 deletions tests/neg/i20546.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import NamedTuple.{NamedTuple, AnyNamedTuple}

type And[X <: Boolean, Y <: Boolean] <: Boolean = (X, Y) match
case (true, true) => true
case _ => false
type AndLambda = [X <: Boolean, Y <: Boolean] =>> And[X, Y]

trait Expr2[Result, Scalar <: Boolean]:
type StripScalar[E] = E match
case Expr2[_, s] => s

type AllScalar[A <: AnyNamedTuple] = Tuple.Fold[Tuple.Map[NamedTuple.DropNames[A], StripScalar], true, AndLambda] // error: cyclic


object Minimization:
type And[X <: Boolean, Y <: Boolean] = (X, Y) match
case (true, true) => true
case _ => false

type AndLambda = [X <: Boolean, Y <: Boolean] =>> And[X, Y]

type All[A <: Tuple] = Tuple.Fold[A, true, AndLambda] // error: cyclic
Loading