Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rest of the warn tests from neg to warn (batch 3) #19244

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

szymon-rd
Copy link
Contributor

@szymon-rd szymon-rd commented Dec 11, 2023

The last batch of tests, move tests other than tests/init/neg and tests/neg to warn.
PR 4/5 (merge consecutively, per Nicolas' suggestion

Split up version of #18829

@szymon-rd szymon-rd changed the title Move rest of the warn tests from neg to warn Move rest of the warn tests from neg to warn (batch 3) Dec 11, 2023
@szymon-rd szymon-rd force-pushed the move-error-warn-b2 branch 2 times, most recently from 1e740e2 to 69d1de3 Compare January 15, 2024 10:59
Base automatically changed from move-error-warn-b2 to main January 19, 2024 15:36
@szymon-rd szymon-rd force-pushed the move-error-warn-b3 branch 2 times, most recently from c96a43c to 2b68e23 Compare January 22, 2024 13:33
@@ -1,13 +0,0 @@
//> using options -Xfatal-warnings

class Test {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in tests/warn already, was just left behind

@szymon-rd szymon-rd force-pushed the move-error-warn-b3 branch 3 times, most recently from 93bb0c2 to c54633f Compare January 24, 2024 17:17
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should not be changed yet

@szymon-rd szymon-rd merged commit 453658b into main Jan 25, 2024
37 checks passed
@szymon-rd szymon-rd deleted the move-error-warn-b3 branch January 25, 2024 17:27
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
WojciechMazur added a commit that referenced this pull request Jun 28, 2024
…LTS (#20853)

Backports #19244 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants