Completion assert diffs will now show completion source #18890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Nov 10, 2023
tgodzik
added
the
area:presentation-compiler
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 25, 2024
Previously failed assertions showed a side by side diff of expected vs obtained completions: <img width="275" alt="Screenshot 2023-11-09 at 18 28 46" src="https://github.com/lampepfl/dotty/assets/48657087/c80fbc71-7e58-4cba-b302-b4dfeff9bcec"> And now: <img width="311" alt="Screenshot 2023-11-09 at 18 29 31" src="https://github.com/lampepfl/dotty/assets/48657087/829933c7-31c6-4c26-a20c-4d426eb5c11b"> This is extremely useful when debugging the completions, as we have multiple sources and finding what specific completion comes from is just a waste of time. There is also a chance that we'd want to not include this info in data, but this is minimal trade-off for a significant boost when working on PC. [Cherry-picked e196dec]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously failed assertions showed a side by side diff of expected vs obtained completions:
And now:
This is extremely useful when debugging the completions, as we have multiple sources and finding what specific completion comes from is just a waste of time.
There is also a chance that we'd want to not include this info in data, but this is minimal trade-off for a significant boost when working on PC.