scala 3 compiler version msg is written to stdout, not stderr #18845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncgl-git
changed the title
Co-authored-by: Nicolas Stucki <[email protected]>
bishabosha
reviewed
Nov 22, 2023
| @@ -130,7 +132,8 @@ trait CliCommand: | |||
| report.echo(ifErrorsMsg) | |||
| None | |||
| else if settings.version.value then | |||
| report.echo(versionMsg) | |||
| // ctx defaults to Console.err | |||
| ConsoleReporter(writer = new PrintWriter(Console.out, true)).printMessage(versionMsg) | |||
There was a problem hiding this comment.
I think this should be handled by the reporter instead, then in the ConsoleReporter you can add an extra writer for where echo messages go (set to Console.out by default), and intercept Info diagnostics in doReport to send to the echo writer. This is what Scala 2 does.
Typically we do want all echo messages to go be visible in the same UI as the warnings/errors (e.g. in an IDE so you get the info messages in a dedicated window, rather than suddenly an extra Console.out log appearing).
|
Superseded by #20328 I was looking for a good first issue. Thanks for taking a first swing. I think I took bishabosha's constructive criticism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets issue 16701
New to Scala, looking for constructive criticism and suggestions if this is a bad way to do this!