Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary guard from migration warnings #18827

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Remove unnecessary guard from migration warnings #18827

merged 1 commit into from
Nov 3, 2023

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 2, 2023 •
edited
Loading

Note that the errorOrMigrationWarning is only emitted on future and the patch on future-migration.

@nicolasstucki nicolasstucki self-assigned this Nov 2, 2023
@nicolasstucki nicolasstucki marked this pull request as ready for review November 3, 2023 08:01
@nicolasstucki nicolasstucki merged commit dc012c3 into scala:main Nov 3, 2023
18 checks passed
@nicolasstucki nicolasstucki deleted the remove-unnecessary-guard-from-migration-warnings branch November 3, 2023 10:22
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @dwijnand @Kordyjan