Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error detected in review of #18699 #18781

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Fix error detected in review of #18699 #18781

merged 3 commits into from
Oct 30, 2023

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 28, 2023

No description provided.

@odersky odersky requested a review from Linyxus October 28, 2023 17:00
@odersky odersky added the cc-experiment Intended to be merged with cc-experiment branch on origin label Oct 29, 2023
Linyxus
Linyxus approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Linyxus Linyxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Linyxus Linyxus merged commit 22aaabb into scala:main Oct 30, 2023
18 checks passed
@Linyxus Linyxus deleted the followup-18699 branch October 30, 2023 12:28
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linyxus Linyxus Linyxus approved these changes

Assignees

@Linyxus Linyxus

Labels
cc-experiment Intended to be merged with cc-experiment branch on origin
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @Linyxus @Kordyjan