Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back experimental.relaxedExtensionImports language import #18643

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 3, 2023

This is to keep MiMa happy.

Not sure what the policy should be. At some point we might want to simply drop the import since it no longer does anything, but maybe we should wait a bit with it?

This is to keep MiMa happy.

Not sure what the policy should be. At some point we might want to simply
drop the import since it no longer does anything, but maybe we should wait a bit
with it?
@odersky odersky marked this pull request as ready for review October 3, 2023 22:09
@sjrd
Copy link
Member

sjrd commented Oct 4, 2023

I guess .tasty files contain references to these things through in import nodes? If yes, we indeed have to keep those (forever). Otherwise we can remove them after a while and we can ignore MiMa.

@odersky
Copy link
Contributor Author

odersky commented Oct 4, 2023

But experimental imports count as experimental. So as far as Tasty is concerned, they should be analogous to a reference to an experimental definition, no? Which means we can remove them, after giving a decent deprecation interval. Or did I overlook something here?

@odersky odersky merged commit 76df8d9 into scala:main Oct 4, 2023
18 checks passed
@odersky odersky deleted the fix-mima branch October 4, 2023 11:43
@sjrd
Copy link
Member

sjrd commented Oct 4, 2023

Oh do they? If they indeed count as experimental themselves, then yes we can eventually remove them.

@odersky
Copy link
Contributor Author

odersky commented Oct 4, 2023

They are experimental in the sense that you can declare an experimental import only in code that's itself experimental.

@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants