WIP: changes to community build projects to build with -Yflexible-types #18172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
force-pushed
the
flexible-types-community-build
branch
5 times, most recently
from
6a94eb8 to
7f40306
Compare
olhotak
force-pushed
the
flexible-types-community-build
branch
5 times, most recently
from
49238e3 to
15efacf
Compare
olhotak
force-pushed
the
flexible-types-community-build
branch
from
15efacf to
df39b66
Compare
olhotak
force-pushed
the
flexible-types-community-build
branch
from
f0ae943 to
dbeef94
Compare
This is because scalatest uses scala-xml and we compiled that without explicit nulls. Ideally we would use flexible types on Scala code compiled without explicit nulls, in addition to on Java-defined code. Then it might be feasible to port scalatest to explicit nulls.
olhotak
force-pushed
the
flexible-types-community-build
branch
from
dbeef94 to
43e8bbc
Compare
|
Rebased (manually, with some minor improvements) now that #18112 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to explore and discuss how many changes are required to the community build programs to make them work with -Yexplicit-nulls and -Yflexible-types.
Depends on #18112 .