Sync with the stable documentation branch #17614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fixes #15927 Check for whether the non-scala3 parent exists before checking the start and end of the span to confirm whether the span exists in getParentsAsTreeSymbolTuples.
…age in worksheets in the Scala Plugin for IntelliJ IDEA - Calling `setOut/setErr` in a concurrent environment without any synchronization (such as the Scala compile server in the Scala Plugin for IntelliJ IDEA, which is used to execute Scala 3 worksheets) can lead to unpredictable outcomes where the out/err streams are not restored properly after changing. - This change adds a new default method `redirectOutput` which can be overriden by others to control the redirecting behavior of the REPL driver.
Increased timeout due to timeouts when running on dotty community build
The issue was in the encoding into `{ExprMatchModule,TypeMatchModule}.unapply`.
Specifically with the `TypeBindings` argument. This arguments holds the
list of type variable definitions (`tpd.Bind` trees). We used a `Tuple`
to list all the types inside. The problem is that higher-kinded type
variables do not conform with the upper bounds of the tuple elements.
The solution is to use an HList with any-kinded elements.
This is mainly a cleanup.
This was accidentally moved before of the `if (!param.tpt.isEmpty)` guard in 0f7c3ab#diff-8c9ece1772bd78160fc1c31e988664586c9df566a1d22ff99ef99dd6d5627a90R1534 Fixes #18276
This reverts commit 5bafff7.
…18440) Reverts #17457. This fix caused significant challenges in maintaining the source compatibility. We decided not to include it in 3.3.1. It will still be a part of 3.4 and future Scala Next versions. It is possible that in the future, an improved version of this fix will make it to one of 3.3.x releases.
Previously, we rejected the case where a symbol of a self type selection was private if was not of the enclosing class. But that symbol could shadow a non-private symbol in a base class, so have to treat that case as well. Fixes #18631
This reverts commit 9571b42.
Also fix typos in older changelogs
Kordyjan
force-pushed
the
language-reference-stable
branch
from
c75b81d to
99ca930
Compare
|
what is the blocker here @Kordyjan, who can work on this? |
`-source future` is still required as of 3.3 LTS.
Kordyjan
added a commit
that referenced
this pull request
Oct 18, 2023
Replaces #17614 This PR is semi-automatically generated to synchronize `language-reference-stable` with `main`. It takes all commits from the first branch that are not present on the second and filters out all that were backported from `main` or have more than one parent. Then it examines changes introduced by each commit. Changes are divided into three groups: - safe - those affect files in `changelogs`, `docs`, `scaladoc`, and `scaladoc-testcases` directories or any `**.md` file. - potentially safe - affect files in `project` direcotry - unsafe - all other modifications Commits only having safe changes were cherry-picked. Those having any potentially safe changes and those that contained both safe and unsafe changes were examined individually. Other commits were skipped. Running a script and answering about each questionable commit took less than 10 minutes, and as a result, we have no conflicts. Working on #17614 would have required hours of fixing dozens of conflicts resulting from merging changes cherry-picked from the `main` branch. It could also have led to subtle problems. If there is no problem with this approach, I'll modify the script slightly and make it a part of a CI instead of the current step that tries to merge the documentation branch to `main` after every change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is syncing the main with changes from language-reference-stable.
It was created automatically after 8810943 by @Kordyjan