Move warn tests from tests/neg to tests/warn: Batch 2 (#19243)

The second batch of tests moved from tests/neg to tests/warn. PR 3/5 (merge consecutively, per [Nicolas' suggestion](#18829 (review)) Split up version of #18829
scala · Jan 19, 2024 · cacf2b6 · cacf2b6
2 parents 36ee954 + 69d1de3
commit cacf2b6
Show file tree

Hide file tree

Showing 83 changed files with 428 additions and 436 deletions.
diff --git a/tests/neg-deep-subtype/3324b.scala b/tests/neg-deep-subtype/3324b.scala
diff --git a/tests/neg-deep-subtype/3324f.scala b/tests/neg-deep-subtype/3324f.scala
diff --git a/tests/neg/14034b.scala b/tests/neg/14034b.scala
diff --git a/tests/neg/17284.scala b/tests/neg/17284.scala
diff --git a/tests/neg/18493.check b/tests/neg/18493.check
diff --git a/tests/neg/avoid-warn-deprecation.scala b/tests/neg/avoid-warn-deprecation.scala
diff --git a/tests/neg/main-functions-nameclash.scala b/tests/neg/main-functions-nameclash.scala
diff --git a/tests/neg/manifest-summoning-b.scala b/tests/neg/manifest-summoning-b.scala
diff --git a/tests/neg/matchable.scala b/tests/neg/matchable.scala
diff --git a/tests/neg/old-syntax.scala b/tests/neg/old-syntax.scala
diff --git a/tests/neg/ovlazy.scala b/tests/neg/ovlazy.scala
diff --git a/tests/neg/private-this-3.4.scala b/tests/neg/private-this-3.4.scala
diff --git a/tests/neg/private-this-future-migration.scala b/tests/neg/private-this-future-migration.scala
diff --git a/tests/neg/quote-simple-hole.scala b/tests/neg/quote-simple-hole.scala
diff --git a/tests/neg/refinements-this.scala b/tests/neg/refinements-this.scala
diff --git a/tests/neg/refutable-pattern-binding-messages.check b/tests/neg/refutable-pattern-binding-messages.check
@@ -22,24 +22,24 @@
    | If the narrowing is intentional, this can be communicated by adding the `case` keyword before the full pattern,
    | which will result in a filtering for expression (using `withFilter`).
    | This patch can be rewritten automatically under -rewrite -source 3.2-migration.
--- Error: tests/neg/refutable-pattern-binding-messages.scala:5:14 ------------------------------------------------------
-5 |  val Positive(p) = 5                     // error: refutable extractor
+-- Warning: tests/neg/refutable-pattern-binding-messages.scala:5:14 ----------------------------------------------------
+5 |  val Positive(p) = 5                     // warn: refutable extractor
   |      ^^^^^^^^^^^^^^^
   |      pattern binding uses refutable extractor `Test.Positive`
   |
   |      If this usage is intentional, this can be communicated by adding `: @unchecked` after the expression,
   |      which may result in a MatchError at runtime.
   |      This patch can be rewritten automatically under -rewrite -source 3.2-migration.
--- Error: tests/neg/refutable-pattern-binding-messages.scala:10:20 -----------------------------------------------------
-10 |  val i :: is = List(1, 2, 3)             // error: pattern type more specialized
+-- Warning: tests/neg/refutable-pattern-binding-messages.scala:10:20 ---------------------------------------------------
+10 |  val i :: is = List(1, 2, 3)             // warn: pattern type more specialized
    |                ^^^^^^^^^^^^^
    |        pattern's type ::[Int] is more specialized than the right hand side expression's type List[Int]
    |
    |        If the narrowing is intentional, this can be communicated by adding `: @unchecked` after the expression,
    |        which may result in a MatchError at runtime.
    |        This patch can be rewritten automatically under -rewrite -source 3.2-migration.
--- Error: tests/neg/refutable-pattern-binding-messages.scala:16:10 -----------------------------------------------------
-16 |  val 1 = 2                               // error: pattern type does not match
+-- Warning: tests/neg/refutable-pattern-binding-messages.scala:16:10 ---------------------------------------------------
+16 |  val 1 = 2                               // warn: pattern type does not match
    |          ^
    |        pattern's type (1 : Int) does not match the right hand side expression's type (2 : Int)
    |

diff --git a/tests/neg/refutable-pattern-binding-messages.scala b/tests/neg/refutable-pattern-binding-messages.scala
@@ -1,17 +1,17 @@
-//> using options -Werror
+
 object Test {
   // refutable extractor
   object Positive { def unapply(i: Int): Option[Int] = Some(i).filter(_ > 0) }
-  val Positive(p) = 5                     // error: refutable extractor
+  val Positive(p) = 5                     // warn: refutable extractor
   for Positive(i) <- List(1, 2, 3) do ()  // error: refutable extractor
 
   // more specialized
   val xs: List[AnyRef] = ???
-  val i :: is = List(1, 2, 3)             // error: pattern type more specialized
+  val i :: is = List(1, 2, 3)             // warn: pattern type more specialized
   for ((x: String) <- xs) do ()           // error: pattern type more specialized
 
   // does not match
   val ys: List[Option[?]] = ???
   for none @ None <- ys do ()             // error: pattern type does not match
-  val 1 = 2                               // error: pattern type does not match
+  val 1 = 2                               // warn: pattern type does not match
 }
diff --git a/tests/neg/rewrite-messages.scala b/tests/neg/rewrite-messages.scala
diff --git a/tests/neg/strict-pattern-bindings-3.2.scala b/tests/neg/strict-pattern-bindings-3.2.scala
diff --git a/tests/neg/symbolic-packages.scala b/tests/neg/symbolic-packages.scala
diff --git a/tests/neg/warn-value-discard.check b/tests/neg/warn-value-discard.check
diff --git a/tests/neg/with-type-operator-future-migration.scala b/tests/neg/with-type-operator-future-migration.scala
diff --git a/tests/warn/14034b.scala b/tests/warn/14034b.scala
@@ -0,0 +1,15 @@
+//> using options  -deprecation
+
+@deprecated trait Exp
+@deprecated val exp = 1
+
+def test1 = exp // warn
+def test2(a: Exp) = () // warn
+
+type Foo0 = Exp // warn
+type Foo = Option[Exp] // warn
+type Bar = Option[exp.type] // warn
+type Baz = Exp | Int // warn
+type Quux = [X] =>> X match
+  case Exp => Int // warn
+type Quuz[A <: Exp] = Int // warn
diff --git a/tests/neg/15981.check → tests/warn/15981.check b/tests/neg/15981.check → tests/warn/15981.check
@@ -1,5 +1,5 @@
--- [E092] Pattern Match Error: tests/neg/15981.scala:4:45 --------------------------------------------------------------
-4 |    override def equals(any: Any): Boolean = any.isInstanceOf[PosInt] // error
+-- [E092] Pattern Match Unchecked Warning: tests/warn/15981.scala:4:45 -------------------------------------------------
+4 |    override def equals(any: Any): Boolean = any.isInstanceOf[PosInt] // warn
   |                                             ^^^
   |                                  the type test for PosInt cannot be checked at runtime because it's a local class
   |

diff --git a/tests/neg/15981.scala → tests/warn/15981.scala b/tests/neg/15981.scala → tests/warn/15981.scala
@@ -1,6 +1,6 @@
-//> using options -Werror
+
 val _ = locally{
   sealed abstract class PosInt(val value: Int) {
-    override def equals(any: Any): Boolean = any.isInstanceOf[PosInt] // error
+    override def equals(any: Any): Boolean = any.isInstanceOf[PosInt] // warn
   }
 }
diff --git a/tests/neg/17284.check → tests/warn/17284.check b/tests/neg/17284.check → tests/warn/17284.check
@@ -1,5 +1,5 @@
--- [E187] Potential Issue Error: tests/neg/17284.scala:4:6 -------------------------------------------------------------
-4 |  451.synchronized {} // error
+-- [E187] Potential Issue Warning: tests/warn/17284.scala:4:6 ----------------------------------------------------------
+4 |  451.synchronized {} // warn
   |  ^^^^^^^^^^^^^^^^
   |  Suspicious synchronized call on boxed class
   |---------------------------------------------------------------------------------------------------------------------
@@ -8,8 +8,8 @@
   | You called the synchronized method on a boxed primitive. This might not be what
   | you intended.
    ---------------------------------------------------------------------------------------------------------------------
--- [E187] Potential Issue Error: tests/neg/17284.scala:8:4 -------------------------------------------------------------
-8 |  x.synchronized {} // error
+-- [E187] Potential Issue Warning: tests/warn/17284.scala:8:4 ----------------------------------------------------------
+8 |  x.synchronized {} // warn
   |  ^^^^^^^^^^^^^^
   |  Suspicious synchronized call on boxed class
   |---------------------------------------------------------------------------------------------------------------------
@@ -18,8 +18,8 @@
   | You called the synchronized method on a boxed primitive. This might not be what
   | you intended.
    ---------------------------------------------------------------------------------------------------------------------
--- [E187] Potential Issue Error: tests/neg/17284.scala:11:7 ------------------------------------------------------------
-11 |  true.synchronized {} // error
+-- [E187] Potential Issue Warning: tests/warn/17284.scala:11:7 ---------------------------------------------------------
+11 |  true.synchronized {} // warn
    |  ^^^^^^^^^^^^^^^^^
    |  Suspicious synchronized call on boxed class
    |--------------------------------------------------------------------------------------------------------------------

diff --git a/tests/warn/17284.scala b/tests/warn/17284.scala
@@ -0,0 +1,14 @@
+//> using options  -explain
+
+def test =
+  451.synchronized {} // warn
+
+def test2 =
+  val x: Integer = 451
+  x.synchronized {} // warn
+
+def test3 =
+  true.synchronized {} // warn
+
+def test4 =
+  true.hashCode() // success