Patch x: _* into x* (not x *) (#18814)

scala · Nov 2, 2023 · bb82d4c · bb82d4c
2 parents afeb541 + e06022f
commit bb82d4c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/compiler/src/dotty/tools/dotc/parsing/Parsers.scala b/compiler/src/dotty/tools/dotc/parsing/Parsers.scala
@@ -2344,7 +2344,7 @@ object Parsers {
               in.sourcePos(uscoreStart),
               future)
             if sourceVersion == `future-migration` then
-              patch(source, Span(t.span.end, in.lastOffset), " *")
+              patch(source, Span(t.span.end, in.lastOffset), "*")
           else if opStack.nonEmpty then
             report.errorOrMigrationWarning(
               em"""`_*` can be used only for last argument of method application.
@@ -2973,12 +2973,6 @@ object Parsers {
       case p =>
         p
 
-    private def warnStarMigration(p: Tree) =
-      report.errorOrMigrationWarning(
-        em"The syntax `x: _*` is no longer supported for vararg splices; use `x*` instead",
-        in.sourcePos(startOffset(p)),
-        from = future)
-
     /**  InfixPattern ::= SimplePattern {id [nl] SimplePattern}
      */
     def infixPattern(): Tree =

diff --git a/tests/rewrites/rewrites3x.check b/tests/rewrites/rewrites3x.check
@@ -0,0 +1,10 @@
+import scala.{collection as coll, runtime as _, *}
+import coll.*
+
+def f(xs: Int*) = xs.sum
+def test =
+  f(List(1, 2, 3)*)
+
+def g = { implicit (x: Int) =>
+  x + 1
+}