Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commons-lang3 to 3.13.0 #288

Closed

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.apache.commons", artifactId = "commons-lang3" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.commons", artifactId = "commons-lang3" }
}]
labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

@SethTisue SethTisue self-assigned this Sep 18, 2023
@SethTisue
Copy link
Member

SethTisue commented Sep 18, 2023

@SethTisue SethTisue removed their assignment Sep 22, 2023
@SethTisue
Copy link
Member

SethTisue commented Sep 22, 2023

There are some NoSuchMethodErrors printed to the console, but if I understand correctly, those are actually expected.

The actual failure is:

[error] Test scala.compat.java8.LambdaTest.isSerializable failed: java.lang.ClassCastException: Cannot cast scala.compat.java8.LambdaTest$$Lambda$46/1952986284 to scala.compat.java8.LambdaTest$$Lambda$45/2114328507, took 0.016 sec
[error]     at java.lang.Class.cast(Class.java:3369)
[error]     at org.apache.commons.lang3.SerializationUtils.clone(SerializationUtils.java:148)
[error]     at scala.compat.java8.LambdaTest.isSerializable(LambdaTest.java:129)
[error]     ...

and the release notes for the upgrade (https://commons.apache.org/proper/commons-lang/changes-report.html#a3.13.0) do show a number of serialization-related changes

@SethTisue
Copy link
Member

aha! I bet it's apache/commons-lang#1110 — at least, it seems suspiciously similar

let's wait a while and see what happens there

@SethTisue SethTisue marked this pull request as draft September 22, 2023 09:35
@scala-steward
Copy link
Contributor Author

Superseded by #294.

@scala-steward scala-steward deleted the update/commons-lang3-3.13.0 branch November 23, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants