Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP-68: Reference-able Package Objects #100

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lihaoyi
Copy link
Contributor

@lihaoyi lihaoyi commented Dec 14, 2024

No description provided.

@kyouko-taiga kyouko-taiga changed the title SIP-XX: Reference-able Package Objects SIP-68: Reference-able Package Objects Dec 17, 2024
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I am in favor. It clearly improves on the status quo that we can refer to a package object in the natural way, without using the .package encoding.

My only concern is that accepting this proposal would effectively bury the idea of dropping package objects. But on reflection I don't think we will be able to drop package objects anyway for the reasons that were stated here.


## Limitations

* `a.b` only expands to `a.b.package` when used "standalone", i.e. not when part of a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this limitation is necessary and it would be hard to implement. I think we can simply say that in selection path a.b.c, a.b means the full package, not just the package object. But it's OK to have operators. By the time we check valid package object use, we have already expanded out all these operators to selections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants