Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components image to show new version of address component #37

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Pabl0cks
Copy link
Collaborator

@Pabl0cks Pabl0cks commented Oct 1, 2024

After scaffold-eth/scaffold-eth-2#924 we can show the component with the new mode, showing both ENS + address.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scaffoldeth-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 11:23am

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really really sorry for being so nitpicky and I wouldn't spend much time perfecting it if its hard and merge this as it.

But can increase the border-radius a bit here 😅

Screenshot 2024-10-01 at 9 54 24 PM

Maybe a bit less than this but almost there:

Screenshot 2024-10-01 at 9 57 27 PM

@Pabl0cks
Copy link
Collaborator Author

Pabl0cks commented Oct 1, 2024

Really really sorry for being so nitpicky and I wouldn't spend much time perfecting it if its hard and merge this as it.

I had the same feeling and was about to ask to Andrea to tweak it, but then I thought I was being too nitpicky, but I'm glad you had the same need haha

I'll ask her for a new version to be inline with the other components.

@Pabl0cks
Copy link
Collaborator Author

Totally forgot about this PR @technophile-04 , just got the new asset and uploaded it, merging! 🚀

@Pabl0cks Pabl0cks merged commit fa899c3 into main Nov 22, 2024
3 checks passed
@Pabl0cks Pabl0cks deleted the se-components-addressnew branch November 22, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants