Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripted sbt2 compatibility part 2 #261

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Scripted sbt2 compatibility part 2 #261

merged 5 commits into from
Oct 24, 2024

Conversation

BillyAutrey
Copy link
Collaborator

@BillyAutrey BillyAutrey commented Oct 23, 2024 •
edited
Loading

Changes the rest of the scripted tests to be more compatible with sbt 2. There are still two issues preventing full sbt 2 compatibility, but they should be dealt with separately.

  • Switches to sbt task + assertions, because sbt 2 target locations are different.
  • Adds FileAssertions helper to simplify the tasks in build.sbt files.
  • Fixes a few more sbt 0.13 deprecation issues.

Towards #255

@BillyAutrey BillyAutrey mentioned this pull request Oct 23, 2024
Open
@BillyAutrey
Copy link
Collaborator Author

@mkurz this one's ready for a review, too.

@BillyAutrey BillyAutrey mentioned this pull request Oct 24, 2024
Merged
mkurz
mkurz approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkurz mkurz merged commit 9455eaa into sbt:main Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyAutrey @mkurz