Bump sbt-web-build-base to 2.0.1. Fixes #118 #119
Conversation
| @@ -1,3 +1,3 @@ | |||
| addSbtPlugin("com.typesafe.sbt" % "sbt-less" % sys.props("project.version")) | |||
| addSbtPlugin("com.github.sbt" % "sbt-less" % sys.props("project.version")) | |||
There was a problem hiding this comment.
I'm not sure how often people contribute to this project but I had to do a little exploration to understand how best to test my changes. If you're happy for me to do so, I could add an explanatory note to CONTRIBUTING.md (about using scripted to execute the tests)?
Also, would you be open to receiving an additional PR to add a github action that executes the tests when a PR is raised?
There was a problem hiding this comment.
I think because this project extends from sbt-web-build-base this means that sbt-less will now also be published under the same (i.e. com.github.sbt/sbt-less). When publishing locally I can see:
As a consequence, will I also need to change this and/or anything else related to the release flow?
There was a problem hiding this comment.
I didn't look yet, but please change the groupId of this plugin to com.github.sbt
There was a problem hiding this comment.
Also, would you be open to receiving an additional PR to add a github action that executes the tests when a PR is raised?
I added GitHub actions workflows which run the scriptet tests and also for publishing to maven central here:
|
JFYI: I've received an email from Lightbend confirming I've signed the CLA |
|
Thanks, I will take a look at this asap (probably not today) |
|
I did not forget, give me some time. |
|
Hi @mkurz - don't suppose you could take a look at this when you get a chance? |
|
I want to get to sbt-web plugins this week actually, it's not just sbt-less but others as well (gzip, etc.) |
* Bump sbt-web-build-base to 2.0.1 * Bump sbt-js-engine and sbt-web to latest * Bump sbt to 1.9.6 * Refactor to slash syntax in SbtLess.scala * Update groupId of plugins used in tests
mkurz
force-pushed
the
bump-sbt-web-build-base
branch
from
0720a31
to
5686bcb
Compare
mkurz
force-pushed
the
bump-sbt-web-build-base
branch
from
d84e704
to
1dba3ca
Compare
What does this change?
As discussed in #118 the latest version of
sbt-lessappears to be incompatible with the latest version ofsbt-web. To resolve this we need to update thesbt-web-build-baseversion.This change does a couple of things:
sbt-web-build-baseto 2.0.1sbt-js-engineandsbt-webSbtLessis refactored to use slash syntaxHow to test?
It appears as though this project makes use of the sbt scripted test framework for testing sbt plugins.
To test changes we can run
sbt scripted.I tested locally by doing the following:* Publishing a version of the plugin to local maven (sbt publishM2)* For each project inside./sbt-test/sbt-less-plugin:* Ensuring the project compiles and uses the locally published version of the plugin* Execute the test instructions and confirm the expectations succeedNote that some tests failed, e.g.:
I don't believe these errors are caused by this change because I believe this issue has already been reported and there is an open PR to resolve this. Please correct me if I'm wrong!